Skip to content

section2 2x2 tiles #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 23, 2020
Merged

section2 2x2 tiles #151

merged 3 commits into from
Jan 23, 2020

Conversation

joelachance
Copy link
Collaborator

@joelachance joelachance commented Jan 21, 2020

Adds 2x2 tiles, a rollover effect, and updated the title to 'Key Features'. Removes icons (for now).

Resolves #84

…, and a rollover effect. Updated the section2 title to Key Features.
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, liking the 2x2 layout and hover effect. Icons (or color, or...) could perhaps be added back later, for now I agree - let's get this in first.

I did notice that the "Key features" title and the title of the "Ecosystem" section below are now styled differently. I don't have a strong preference for a style, however I think that consistency here would be good. If this is addressed or TODO in another PR, I missed that - let me know if you want to merge as is or fix here.

@joelachance
Copy link
Collaborator Author

I'd like to update the 'Ecosystem' header to look more like this one. Also, I hope the wording update from 'In a Nutshell' to 'Key Features' is welcomed, I liked how PyTorch had their 'key features' section.

If that sounds good, I say we merge and I'll fix the Ecosystem header in the tab PR.

@joelachance joelachance merged commit 7047f9c into master Jan 23, 2020
@joelachance joelachance deleted the feature/84-nutshell branch January 23, 2020 02:47
@rgommers
Copy link
Member

Agreed, I like "key features". It does point at something a little different (e.g. open source isn't a key feature I'd say) so we may want to edit/extend a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homepage - "In a nutshell"
3 participants